Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve run-time errors when using deprecated sync error handling #6272

Merged

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Apr 27, 2021

Fixes a should-be-obvious issue where we were making sure dest was undefined, then trying to set a property on it.

fixes #6271

Fixes a should-be-obvious issue where we were making sure `dest` was `undefined`, then trying to set a property on it.

fixes ReactiveX#6271
@leggechr
Copy link
Contributor

Tests are passing in google with this fix. LGTM

@benlesh benlesh merged commit 35daaf7 into ReactiveX:master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

100% chance of runtime error if config.useDeprecatedSyncErrorHandling is enabled
2 participants