fix(merge): single array is not an array of sources #6211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Prior to this change, the static
mergebehaved in a manner that was contrary to its types: it treated a single array as an array of sources. The staticconcatdid not do this, so changing aconcatto amergeor vice versa would effect wildly different behaviour if a single array was passed.This PR adds a failing test and removes the call to
argsOrArgArray- which did the sniffing and unpacking.Regarding v7, there are a bunch of inconsistencies between
concat,merge,race,combineLatest,forkJoinandzip, but most can be addressed through the application of deprecations. This change, however, addresses an inconsistency in the implementation.Related issue (if exists): Nope