fix(pluck): operator breaks with null/undefined inputs. #5524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anirudhvarma12
changed the title
cartant
requested changes
Jun 23, 2020
…ing converted to undefined
cartant
approved these changes
Jun 24, 2020
cartant
approved these changes
Jun 24, 2020
|
@cartant , is there a process to PR getting merged after approval? (Sorry if this is already documented somewhere, I could not find it) |
|
PRs that update actual library code - i.e. not just tests or docs - need to be approved and merged by Ben. |
benlesh
approved these changes
Jun 29, 2020
benlesh
pushed a commit
that referenced
this pull request
Jun 29, 2020
* test(pluck): add failing test case for using null value. * fix(pluck): check for null/undefined object before attempting to access prop * Remove null coalescing when checking values to prevent null values being converted to undefined
|
Merged also into 6.x, although with a slight alteration, as we don't compile with TS 3.9 there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add a fix to prevent the pluck operator from breaking on null or undefined inputs.
Related issue (if exists):
#5505