Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Splat container extension calling dispose on finalize #448

Merged
merged 1 commit into from Dec 22, 2019

Conversation

glennawatson
Copy link
Contributor

The finalize is meant for when the container registrations are complete and allow some containers to mark themselves as immutable.

In the current version we are disposing which will cause a new splat container to be registered, wiping out out registrations.

@glennawatson glennawatson requested a review from a team December 22, 2019 03:34
@codecov
Copy link

codecov bot commented Dec 22, 2019

Codecov Report

Merging #448 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #448   +/-   ##
=======================================
  Coverage   66.82%   66.82%           
=======================================
  Files          70       70           
  Lines        3946     3946           
  Branches      394      394           
=======================================
  Hits         2637     2637           
  Misses       1237     1237           
  Partials       72       72
Impacted Files Coverage Δ
.../Platforms/ServiceLocationDrawingInitialization.cs 0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca1b2c3...422f02b. Read the comment docs.

@glennawatson glennawatson merged commit e15211a into master Dec 22, 2019
@glennawatson glennawatson deleted the glennawatson-fix-prism branch December 22, 2019 04:07
@lock lock bot locked and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants