Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add Prism DI extensions #431

Merged
merged 2 commits into from Nov 20, 2019
Merged

Conversation

glennawatson
Copy link
Contributor

@glennawatson glennawatson commented Nov 20, 2019

Change the locator to be accessible in a method

Update dependencies where appropriate

Fixes #358

Change the locator to be accessible in a method

Update dependencies where appropriate
@glennawatson glennawatson requested a review from a team November 20, 2019 11:46
@glennawatson glennawatson reopened this Nov 20, 2019
@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #431 into master will increase coverage by 2.12%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #431      +/-   ##
==========================================
+ Coverage   64.65%   66.77%   +2.12%     
==========================================
  Files          70       70              
  Lines        4111     3943     -168     
  Branches      419      394      -25     
==========================================
- Hits         2658     2633      -25     
+ Misses       1377     1237     -140     
+ Partials       76       73       -3
Impacted Files Coverage Δ
src/Splat/MemoizingMRUCache.cs 56.32% <0%> (ø) ⬆️
src/Splat/AssemblyFinder.cs 0% <0%> (ø) ⬆️
src/Splat/ServiceLocation/Locator.cs 76.92% <100%> (ø) ⬆️
.../Splat/ServiceLocation/DependencyResolverMixins.cs 37.5% <100%> (ø) ⬆️
.../Splat/ServiceLocation/ModernDependencyResolver.cs 50.74% <66.66%> (-1.5%) ⬇️
src/Splat.Drawing/Colors/SplatColor.KnownColors.cs 0% <0%> (-10.93%) ⬇️
src/Splat.NLog/NLogLogger.cs 73.74% <0%> (-0.84%) ⬇️
src/Splat.Drawing/Colors/SplatColor.cs 24.6% <0%> (+11.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a727eb9...92b3f8b. Read the comment docs.

@glennawatson glennawatson merged commit fb91958 into master Nov 20, 2019
@glennawatson glennawatson deleted the glennawatson-make-prism-di branch November 20, 2019 12:18
@lock lock bot locked and limited conversation to collaborators Feb 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Add Prism DI adapter
1 participant