Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Keep users from breaking with a runtime constructor change #345

Merged
merged 1 commit into from Jun 21, 2019

Conversation

glennawatson
Copy link
Contributor

Resolves issue in reactiveui/ReactiveUI#2081

@glennawatson glennawatson requested a review from a team June 21, 2019 10:24
@dpvreony
Copy link
Member

java sdk issue in build?

@glennawatson
Copy link
Contributor Author

I've triggered a re-build, see if it goes away. I'm just hoping it's not a microsoft build pipeline deployment that's broken.

@glennawatson
Copy link
Contributor Author

glennawatson commented Jun 21, 2019

@codecov
Copy link

codecov bot commented Jun 21, 2019

Codecov Report

Merging #345 into master will decrease coverage by 0.09%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #345     +/-   ##
=========================================
- Coverage   70.69%   70.59%   -0.1%     
=========================================
  Files          65       65             
  Lines        3545     3551      +6     
  Branches      317      317             
=========================================
+ Hits         2506     2507      +1     
- Misses        997     1001      +4     
- Partials       42       43      +1
Impacted Files Coverage Δ
src/Splat/MemoizingMRUCache.cs 56.32% <42.85%> (-2.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 161eeda...8fce1f4. Read the comment docs.

@glennawatson glennawatson merged commit 8999eb2 into master Jun 21, 2019
@delete-merged-branch delete-merged-branch bot deleted the glennawatson-fix-mru-cache-constructor branch June 21, 2019 17:35
@lock lock bot locked and limited conversation to collaborators Sep 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants