fix: android bitmap skip dynamic and handle exceptions #337
Conversation
|
Thanks for doing this, was going to look into it this weekend but saves me the hassle. |
|
The build failure is weird, it seems to be borking on the temporary version string, which was previously always accepted. Wonder if they updated the Azure DevOps versions or something that has broken it. I will investigate. |
|
The build issue is due to you having the rare case of a all numeric git commit id for the first 10 characters. |
|
If you commit something again it'll likely go away. |
|
will push another commit when I get back |
|
Correction, it's the rare case where you have a sequence starting with 0 and all number sequence. |
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
=======================================
Coverage 70.68% 70.68%
=======================================
Files 65 65
Lines 3544 3544
Branches 316 316
=======================================
Hits 2505 2505
Misses 997 997
Partials 42 42Continue to review full report at Codecov.
|
shouldnt be needed if the gettypesfromassembly behaves on exceptions
|
removed the dynamic filter piece as the exception handling block should cater for it |
glennawatson
changed the title
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Mitigates type load exceptions as described in #330
What is the current behavior? (You can also link to an open issue here)
Can throw exceptions and not handled as graceful as they could be.
What is the new behavior (if this is a feature change)?
skip dynamic assemblies
catch exceptions, log them and return the types we did manage to load.
What might this PR break?
If dynamic assemblies are used for generating drawable resources, these will no longer load.
behaviour change that it logs out reflection type load exceptions but will continue if it can.
Please check if the PR fulfills these requirements
Other information:
Needs a sense check
Also I've queried whether GetExportedTypes should be used instead?