feature: Add ReactiveUI.Maui #2879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding ReactiveUI.Events.Maui wild car the Maui preview version
| @@ -1,6 +1,6 @@ | |||
| <Project Sdk="MSBuild.Sdk.Extras"> | |||
| <PropertyGroup> | |||
| <TargetFrameworks>netstandard2.0;net5.0;Xamarin.iOS10;Xamarin.Mac20;Xamarin.TVOS10;MonoAndroid10.0;tizen40</TargetFrameworks> | |||
| <TargetFrameworks>netstandard2.0;net5.0;Xamarin.iOS10;Xamarin.Mac20;Xamarin.TVOS10;MonoAndroid10.0;tizen40;net6.0</TargetFrameworks> | |||
| <TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">$(TargetFrameworks);net461;net472;uap10.0.16299;netcoreapp3.1;net5.0-windows;net5.0-windows10.0.19041</TargetFrameworks> | |||
There was a problem hiding this comment.
Before next major goes out I think we need to remove our uap/net5.0-windows etc targets, might mean we move uap out into its own package but i'm fine with that.
This should use conversionHint to determine whether this is locale-aware or notThis comment was generated by todo based on a
|
RLittlesII
force-pushed
the
feature/maui
branch
2 times, most recently
from
cc8a71f
to
d34f906
Compare
remove from solution remove project
RLittlesII
force-pushed
the
feature/maui
branch
from
d34f906
to
2102548
Compare
Codecov Report
@@ Coverage Diff @@
## main #2879 +/- ##
=======================================
Coverage 71.95% 71.96%
=======================================
Files 144 144
Lines 5007 5008 +1
=======================================
+ Hits 3603 3604 +1
Misses 1404 1404
Continue to review full report at Codecov.
|
glennawatson
approved these changes
Aug 19, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding ReactiveUI.Events.Maui
wild car the Maui preview version
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
What might this PR break?
Please check if the PR fulfills these requirements
Other information: