Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in splat 7.3.6 #2081

Closed
SimonCropp opened this issue Jun 21, 2019 · 10 comments
Closed

Breaking change in splat 7.3.6 #2081

SimonCropp opened this issue Jun 21, 2019 · 10 comments

Comments

@SimonCropp
Copy link

just an FYI, MemoizingMRUCache now has an extra required runtime parameter reactiveui/splat@161eeda

image

which means your consumers will get this exception at runtime

System.MissingMethodException
Method not found: 'Void Splat.MemoizingMRUCache`2..ctor(System.Func`3<!0,System.Object,!1>, Int32, System.Action`1<!1>)'.
   at ReactiveUI.ReactiveNotifyPropertyChangedMixin..cctor()
@SimonCropp SimonCropp added the bug label Jun 21, 2019
@open-collective-bot
Copy link

open-collective-bot bot commented Jun 21, 2019

Hey @SimonCropp 👋,

Thank you for opening an issue. We will get back to you as soon as we can. Also, check out our Open Collective and consider backing us.

https://opencollective.com/reactiveui

PS.: We offer priority support for all backers. Don't forget to add priority label when you start backing us 😄

An advanced, composable, functional reactive model-view-viewmodel framework for all .NET platforms!

@SimonCropp
Copy link
Author

updating to the newest splat should fix this. let me know if u want a PR

@glennawatson
Copy link
Contributor

We use the LibraryRange feature for NuGet so should automatically fix itself when we go to next version on NuGet. I am adding those constructors back though for other packages that rely on Splat.

@SimonCropp
Copy link
Author

@glennawatson thanks, and no rush. i only noticed due to a dependabot auto update

@paul-charlton
Copy link

Hi, Is there a workaround for this in the meantime? The latest release version of splat is 7.3.6, @SimonCropp did you mean use the pre-release version of splat 8.0.0-dotnet3-preview.8 ?

@glennawatson
Copy link
Contributor

Just explicitly use the old version for the moment.

@glennawatson
Copy link
Contributor

I would of released a fix by now but azure DevOps broke today unfortunately

@glennawatson
Copy link
Contributor

Fixed by reactiveui/splat#345

@SimonCropp
Copy link
Author

@glennawatson thanks :)

@lock lock bot added the outdated label Sep 20, 2019
@lock lock bot locked and limited conversation to collaborators Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants