Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] _commit never disposed #656

Open
DennisWelu opened this issue Feb 5, 2021 · 0 comments
Open

[BUG] _commit never disposed #656

DennisWelu opened this issue Feb 5, 2021 · 0 comments
Labels
Bug

Comments

@DennisWelu
Copy link

DennisWelu commented Feb 5, 2021 •
edited

I was browsing the repo source and happened to notice this block. It appears that the intent was to check for and dispose the "_commit" field, not to re-check the "_begin" field. Looks like a classic copy/paste bug.

https://github.com/reactiveui/Akavache/blob/main/src/Akavache.Sqlite3/Queues/OperationQueue.cs#L375-L378

It appears that the _commit will not be disposed.
@DennisWelu DennisWelu added the Bug label Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DennisWelu