Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve propTypes validation #156

Closed
adamkudrna opened this issue Sep 29, 2020 · 1 comment
Closed

Improve propTypes validation #156

adamkudrna opened this issue Sep 29, 2020 · 1 comment
Assignees
Projects

Comments

@adamkudrna
Copy link
Member

adamkudrna commented Sep 29, 2020

We would like to validate that:

  • mutually exclusive props aren't set at the same time
  • parent component of a multi-level component only receives children of certain type (eg. Toolbar only accepts ToolbarItem and ToolbarGroup and nothing else)
  • component passed in props where a given type is required (i.e. ScrollView prop in the Modal component)

Make use of https://github.com/airbnb/prop-types ?

Relates to facebook/prop-types#327 (comment)

@adamkudrna adamkudrna added this to the v1.0.0 milestone Sep 29, 2020
@adamkudrna adamkudrna added this to Backlog in The Board Oct 1, 2020
@adamkudrna adamkudrna modified the milestone: v1.0.0 Oct 6, 2020
@adamkudrna adamkudrna removed this from Tracking in The Board Oct 8, 2020
@adamkudrna adamkudrna added this to Components in Feature Ideas Oct 8, 2020
@adamkudrna adamkudrna moved this from 📦 Components to 🤔 General in Feature Ideas Apr 30, 2021
@mbohal mbohal removed this from 🤔 General in Feature Ideas May 20, 2021
@mbohal mbohal added this to 🎬 To do in The Board May 20, 2021
@adamkudrna adamkudrna moved this from 🎬 To do to 🚀 In progress in The Board May 24, 2021
@bedrich-schindler
Copy link
Contributor

We are closing this issue. We've decided that we will not try to validate children as we do not know whether library user will not want to use wrapped version of supported elements which is a thing we are not able to validate in simple way.

The Board automation moved this from 🚀 In progress to 🏁 Done Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
The Board
🏁 Done
2 participants