Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ripple effect shown twice after clicking one time on material top tab after new architecture enabled. #11930

Open
5 of 11 tasks
hpurohit97 opened this issue Apr 10, 2024 · 5 comments

Comments

@hpurohit97
Copy link

hpurohit97 commented Apr 10, 2024

Current behavior

When the user click on the top tab, the screen is smoothly transitioned but the ripple effect is shown multiple times.

Expected behavior

Ripple effect should only come once.

Reproduction

Worked on a personal project, cannot share link here.

Platform

  • Android
  • iOS
  • Web
  • Windows
  • MacOS

Packages

  • @react-navigation/bottom-tabs
  • @react-navigation/drawer
  • @react-navigation/material-top-tabs
  • @react-navigation/stack
  • @react-navigation/native-stack
  • react-native-tab-view

Environment

  • [] I've removed the packages that I don't use
package version
@react-navigation/native 6.1.17
@react-navigation/bottom-tabs 6.5.20
@react-navigation/material-top-tabs 6.6.13
@react-navigation/stack 6.3.29
@react-navigation/native-stack 6.9.13
react-native-safe-area-context 4.9.0
react-native-screens 3.30.1
react-native-gesture-handler 2.15.0
react-native-reanimated 3.8.0
react-native-tab-view 3.5.2
react-native-pager-view 6.2.3
react-native 0.73.6
@hpurohit97 hpurohit97 added the bug label Apr 10, 2024
Copy link

Couldn't find version numbers for the following packages in the issue:

  • @react-navigation/stack

Can you update the issue to include version numbers for those packages? The version numbers must match the format 1.2.3.

The versions mentioned in the issue for the following packages differ from the latest versions on npm:

  • @react-navigation/native (found: 6.1.3, latest: 6.1.17)
  • @react-navigation/bottom-tabs (found: 6.5.4, latest: 6.5.20)
  • @react-navigation/material-top-tabs (found: 6.5.3, latest: 6.6.13)
  • react-native-tab-view (found: 3.5.0, latest: 3.5.2)

Can you verify that the issue still exists after upgrading to the latest versions of these packages?

Copy link

Hey @hpurohit97! Thanks for opening the issue. It seems that the issue doesn't contain a link to a repro.

The best way to get attention to your issue is to provide an easy way for a developer to reproduce the issue.

You can provide a repro using any of the following:

A snack link is preferred since it's the easiest way to both create and share a repro. If it's not possible to create a repro using a snack, link to a GitHub repo under your username is a good alternative. Don't link to a branch or specific file etc. as it won't be detected.

Try to keep the repro as small as possible by narrowing down the minimal amount of code needed to reproduce the issue. Don't link to your entire project or a project containing code unrelated to the issue. See "How to create a Minimal, Reproducible Example" for more information.

You can edit your original issue to include a link to the repro, or leave it as a comment. The issue will be closed automatically after a while if you don't provide a repro.

Copy link

The versions mentioned in the issue for the following packages differ from the latest versions on npm:

  • @react-navigation/native (found: 6.1.3, latest: 6.1.17)
  • @react-navigation/bottom-tabs (found: 6.5.4, latest: 6.5.20)
  • @react-navigation/material-top-tabs (found: 6.5.3, latest: 6.6.13)
  • @react-navigation/stack (found: 6.3.12, latest: 6.3.29)
  • react-native-tab-view (found: 3.5.0, latest: 3.5.2)

Can you verify that the issue still exists after upgrading to the latest versions of these packages?

@KManiKumarReddy
Copy link

I'm on the latest versions and still experience this intermittently, I'll attach a expo snack soon. I'm attaching a video of what's happening
Screen Recording 2024-04-19 at 7 37 04 PM1

@hpurohit97
Copy link
Author

hpurohit97 commented Apr 22, 2024

@KManiKumarReddy I didn't find the reason for this yet. But to disable it we can update material-top-tabs and use tabBarAndroidRipple={radius: 0} in screen options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants