Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add testID and accessibilityLabel to DrawerItem #11168

Merged

Conversation

andrewtremblay
Copy link
Contributor

@andrewtremblay andrewtremblay commented Jan 20, 2023

Added support for testIDs for the tappable DrawerItem and the DrawerItem label

Addresses #7492 and #8906

This was attempted before with #11009 but that PR was closed due to an update in the main branch.

@github-actions
Copy link

Hey andrewtremblay! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines.

@netlify
Copy link

netlify bot commented Jan 20, 2023

Deploy Preview for react-navigation-example ready!

Name Link
🔨 Latest commit 0ef4a2d
🔍 Latest deploy log https://app.netlify.com/sites/react-navigation-example/deploys/63e92d60d67cd30008efe9da
😎 Deploy Preview https://deploy-preview-11168--react-navigation-example.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Can you remove the labeltestID? Ideally users would use the test tool's methods to check the contained text.

Also remove the comments about LinkPressable since it's not relevant to users since it's an implementation detail.

@andrewtremblay
Copy link
Contributor Author

@satya164 your change requests have been addressed in b19a2c5

Copy link
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@satya164 satya164 enabled auto-merge (squash) February 12, 2023 18:18
auto-merge was automatically disabled February 12, 2023 18:19

Merge queue setting changed

@codecov-commenter
Copy link

Codecov Report

Base: 74.09% // Head: 74.09% // No change to project coverage 👍

Coverage data is based on head (0ef4a2d) compared to base (d7ef2bf).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11168   +/-   ##
=======================================
  Coverage   74.09%   74.09%           
=======================================
  Files         176      176           
  Lines        5598     5598           
  Branches     2193     2193           
=======================================
  Hits         4148     4148           
  Misses       1401     1401           
  Partials       49       49           
Impacted Files Coverage Δ
packages/drawer/src/views/DrawerItem.tsx 62.85% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satya164 satya164 added this pull request to the merge queue Feb 12, 2023
@satya164 satya164 removed this pull request from the merge queue Feb 12, 2023
@satya164 satya164 added this pull request to the merge queue Feb 12, 2023
@satya164 satya164 removed this pull request from the merge queue due to the queue being cleared Feb 12, 2023
@satya164 satya164 merged commit 99ff9f7 into react-navigation:main Feb 12, 2023
satya164 pushed a commit that referenced this pull request Feb 12, 2023
Added support for testIDs for the tappable DrawerItem and the DrawerItem
label

Addresses
#7492 and
#8906

This was attempted before with
#11009 but that
PR was closed due to an update in the main branch.
satya164 pushed a commit that referenced this pull request Feb 17, 2023
Added support for testIDs for the tappable DrawerItem and the DrawerItem
label

Addresses
#7492 and
#8906

This was attempted before with
#11009 but that
PR was closed due to an update in the main branch.
satya164 pushed a commit that referenced this pull request Feb 17, 2023
Added support for testIDs for the tappable DrawerItem and the DrawerItem
label

Addresses
#7492 and
#8906

This was attempted before with
#11009 but that
PR was closed due to an update in the main branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants