fix: add ScrollView type to 'getScrollResponder'
#11112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for react-navigation-example ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@TomCorvus I recreated a pull request (the same diff). Could you try yarn add ken0nek/react-navigation.git#react-navigation-native-v6.1.1-gitpkg |
|
@satya164 I recreated #10775 as you suggested. Please review this when you have a chance. Thank you! ref: #10775 (comment) |
It seems to be fixed 👍 |
|
@TomCorvus Thank you for the update! 🤝 |
Codecov ReportBase: 74.11% // Head: 74.11% // No change to project coverage 👍
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #11112 +/- ##
=======================================
Coverage 74.11% 74.11%
=======================================
Files 176 176
Lines 5602 5602
Branches 2197 2197
=======================================
Hits 4152 4152
Misses 1401 1401
Partials 49 49
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
satya164
added a commit
that referenced
this pull request
Feb 12, 2023
Recreation of #10775 due to the git changes. **Motivation** Close #10722 `getScrollResponder` has a type error around `SectionList` due to missing type for `SectionList` ----- FlatList - https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-native/index.d.ts#L4057 ```ts getScrollResponder: () => JSX.Element | null | undefined; ``` SectionList - https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-native/index.d.ts#L4294 ```ts getScrollResponder(): ScrollView | undefined; ``` **Test plan** Use - `@types/react`: `^18.0.15` - `@react-navigation/native`: `ken0nek/react-navigation.git#react-navigation-native-v6.1.1-gitpkg` Check no errors for `useScrollToTop` with `SectionList`. ```ts const sectionList = useRef<SectionList>(null); useScrollToTop(sectionList); ``` Co-authored-by: Satyajit Sahoo <satyajit.happy@gmail.com>
satya164
added a commit
that referenced
this pull request
Feb 17, 2023
Recreation of #10775 due to the git changes. **Motivation** Close #10722 `getScrollResponder` has a type error around `SectionList` due to missing type for `SectionList` ----- FlatList - https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-native/index.d.ts#L4057 ```ts getScrollResponder: () => JSX.Element | null | undefined; ``` SectionList - https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-native/index.d.ts#L4294 ```ts getScrollResponder(): ScrollView | undefined; ``` **Test plan** Use - `@types/react`: `^18.0.15` - `@react-navigation/native`: `ken0nek/react-navigation.git#react-navigation-native-v6.1.1-gitpkg` Check no errors for `useScrollToTop` with `SectionList`. ```ts const sectionList = useRef<SectionList>(null); useScrollToTop(sectionList); ``` Co-authored-by: Satyajit Sahoo <satyajit.happy@gmail.com>
satya164
added a commit
that referenced
this pull request
Feb 17, 2023
Recreation of #10775 due to the git changes. **Motivation** Close #10722 `getScrollResponder` has a type error around `SectionList` due to missing type for `SectionList` ----- FlatList - https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-native/index.d.ts#L4057 ```ts getScrollResponder: () => JSX.Element | null | undefined; ``` SectionList - https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-native/index.d.ts#L4294 ```ts getScrollResponder(): ScrollView | undefined; ``` **Test plan** Use - `@types/react`: `^18.0.15` - `@react-navigation/native`: `ken0nek/react-navigation.git#react-navigation-native-v6.1.1-gitpkg` Check no errors for `useScrollToTop` with `SectionList`. ```ts const sectionList = useRef<SectionList>(null); useScrollToTop(sectionList); ``` Co-authored-by: Satyajit Sahoo <satyajit.happy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreation of #10775 due to the git changes.
Motivation
Close #10722
getScrollResponderhas a type error aroundSectionListdue to missing type forSectionListFlatList - https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-native/index.d.ts#L4057
SectionList - https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-native/index.d.ts#L4294
Test plan
Use
@types/react:^18.0.15@react-navigation/native:ken0nek/react-navigation.git#react-navigation-native-v6.1.1-gitpkgCheck no errors for
useScrollToTopwithSectionList.