Fix useScrollToTop not working when nesting multiple tab navigators #11063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey anthonyguay! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines. |
✅ Deploy Preview for react-navigation-example ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This was referenced Dec 1, 2022
|
Hey autofix-ci[bot]! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines. |
satya164
requested changes
Dec 4, 2022
Codecov ReportBase: 74.29% // Head: 74.17% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #11063 +/- ##
==========================================
- Coverage 74.29% 74.17% -0.12%
==========================================
Files 176 176
Lines 5578 5587 +9
Branches 2182 2186 +4
==========================================
Hits 4144 4144
- Misses 1385 1394 +9
Partials 49 49
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
satya164
requested changes
Dec 4, 2022
…croll-when-multiple-tab-navigators
|
@anthonyguay thanks for getting this is main. We'll finally be able to remove our patch 👍 |
|
Hey! This issue is closed and isn't watched by the core team. You are welcome to discuss the issue with others in this thread, but if you think this issue is still valid and needs to be tracked, please open a new issue with a repro. |
satya164
added a commit
that referenced
this pull request
Dec 7, 2022
…11063) **Motivation** This PR answers this open issue: #11045 When tapping on a bottom tab, the screen scrolls back to the top. However, when adding a second tab navigator at the top of the screen, tapping the bottom tap does not automatically scroll to top anymore. Only tapping the top navigation tab will scroll the screen up. It is expected that the bottom tab tap will still scroll the screen to the top, just like tapping the status bar. **Context** This issue has previously been reported [here](#8586) by [@iirovi](https://github.com/iirovi), and a pull request to fix the issue has been proposed by [@Gregoirevda](https://github.com/Gregoirevda) [here](#9434). Recent changes on main automatically closed the pull request, so I'm posting his solution here again at @satya164's [request](#9434 (comment)). We tested this solution on our app and it works perfectly well. Previously, tapping the bottom tab would not scroll back to the top when a top tab bar was present, but this fixes the issue. You can find the package versions in [the open issue](#11045). **Behavior example** Twitter has both top and bottom navigation bars. When tapping on the bottom tap, the screen scrolls back to the top. Tapping the top tab also scroll to the top. <img src="https://user-images.githubusercontent.com/4307396/205150557-64787dfc-ed77-4a2f-88f3-205b05b6aead.mp4" width="300"> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Satyajit Sahoo <satyajit.happy@gmail.com>
satya164
added a commit
that referenced
this pull request
Dec 7, 2022
…11063) **Motivation** This PR answers this open issue: #11045 When tapping on a bottom tab, the screen scrolls back to the top. However, when adding a second tab navigator at the top of the screen, tapping the bottom tap does not automatically scroll to top anymore. Only tapping the top navigation tab will scroll the screen up. It is expected that the bottom tab tap will still scroll the screen to the top, just like tapping the status bar. **Context** This issue has previously been reported [here](#8586) by [@iirovi](https://github.com/iirovi), and a pull request to fix the issue has been proposed by [@Gregoirevda](https://github.com/Gregoirevda) [here](#9434). Recent changes on main automatically closed the pull request, so I'm posting his solution here again at @satya164's [request](#9434 (comment)). We tested this solution on our app and it works perfectly well. Previously, tapping the bottom tab would not scroll back to the top when a top tab bar was present, but this fixes the issue. You can find the package versions in [the open issue](#11045). **Behavior example** Twitter has both top and bottom navigation bars. When tapping on the bottom tap, the screen scrolls back to the top. Tapping the top tab also scroll to the top. <img src="https://user-images.githubusercontent.com/4307396/205150557-64787dfc-ed77-4a2f-88f3-205b05b6aead.mp4" width="300"> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Satyajit Sahoo <satyajit.happy@gmail.com>
All thanks to you @Gregoirevda ! We're also going to be able to remove the patch 👍 |
satya164
added a commit
that referenced
this pull request
Dec 11, 2022
…11063) **Motivation** This PR answers this open issue: #11045 When tapping on a bottom tab, the screen scrolls back to the top. However, when adding a second tab navigator at the top of the screen, tapping the bottom tap does not automatically scroll to top anymore. Only tapping the top navigation tab will scroll the screen up. It is expected that the bottom tab tap will still scroll the screen to the top, just like tapping the status bar. **Context** This issue has previously been reported [here](#8586) by [@iirovi](https://github.com/iirovi), and a pull request to fix the issue has been proposed by [@Gregoirevda](https://github.com/Gregoirevda) [here](#9434). Recent changes on main automatically closed the pull request, so I'm posting his solution here again at @satya164's [request](#9434 (comment)). We tested this solution on our app and it works perfectly well. Previously, tapping the bottom tab would not scroll back to the top when a top tab bar was present, but this fixes the issue. You can find the package versions in [the open issue](#11045). **Behavior example** Twitter has both top and bottom navigation bars. When tapping on the bottom tap, the screen scrolls back to the top. Tapping the top tab also scroll to the top. <img src="https://user-images.githubusercontent.com/4307396/205150557-64787dfc-ed77-4a2f-88f3-205b05b6aead.mp4" width="300"> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Satyajit Sahoo <satyajit.happy@gmail.com>
satya164
added a commit
that referenced
this pull request
Feb 17, 2023
…11063) **Motivation** This PR answers this open issue: #11045 When tapping on a bottom tab, the screen scrolls back to the top. However, when adding a second tab navigator at the top of the screen, tapping the bottom tap does not automatically scroll to top anymore. Only tapping the top navigation tab will scroll the screen up. It is expected that the bottom tab tap will still scroll the screen to the top, just like tapping the status bar. **Context** This issue has previously been reported [here](#8586) by [@iirovi](https://github.com/iirovi), and a pull request to fix the issue has been proposed by [@Gregoirevda](https://github.com/Gregoirevda) [here](#9434). Recent changes on main automatically closed the pull request, so I'm posting his solution here again at @satya164's [request](#9434 (comment)). We tested this solution on our app and it works perfectly well. Previously, tapping the bottom tab would not scroll back to the top when a top tab bar was present, but this fixes the issue. You can find the package versions in [the open issue](#11045). **Behavior example** Twitter has both top and bottom navigation bars. When tapping on the bottom tap, the screen scrolls back to the top. Tapping the top tab also scroll to the top. <img src="https://user-images.githubusercontent.com/4307396/205150557-64787dfc-ed77-4a2f-88f3-205b05b6aead.mp4" width="300"> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Satyajit Sahoo <satyajit.happy@gmail.com>
satya164
added a commit
that referenced
this pull request
Feb 17, 2023
…11063) **Motivation** This PR answers this open issue: #11045 When tapping on a bottom tab, the screen scrolls back to the top. However, when adding a second tab navigator at the top of the screen, tapping the bottom tap does not automatically scroll to top anymore. Only tapping the top navigation tab will scroll the screen up. It is expected that the bottom tab tap will still scroll the screen to the top, just like tapping the status bar. **Context** This issue has previously been reported [here](#8586) by [@iirovi](https://github.com/iirovi), and a pull request to fix the issue has been proposed by [@Gregoirevda](https://github.com/Gregoirevda) [here](#9434). Recent changes on main automatically closed the pull request, so I'm posting his solution here again at @satya164's [request](#9434 (comment)). We tested this solution on our app and it works perfectly well. Previously, tapping the bottom tab would not scroll back to the top when a top tab bar was present, but this fixes the issue. You can find the package versions in [the open issue](#11045). **Behavior example** Twitter has both top and bottom navigation bars. When tapping on the bottom tap, the screen scrolls back to the top. Tapping the top tab also scroll to the top. <img src="https://user-images.githubusercontent.com/4307396/205150557-64787dfc-ed77-4a2f-88f3-205b05b6aead.mp4" width="300"> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Satyajit Sahoo <satyajit.happy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR answers this open issue: #11045
When tapping on a bottom tab, the screen scrolls back to the top. However, when adding a second tab navigator at the top of the screen, tapping the bottom tap does not automatically scroll to top anymore. Only tapping the top navigation tab will scroll the screen up. It is expected that the bottom tab tap will still scroll the screen to the top, just like tapping the status bar.
Context
This issue has previously been reported here by @iirovi, and a pull request to fix the issue has been proposed by @Gregoirevda here. Recent changes on main automatically closed the pull request, so I'm posting his solution here again at @satya164's request.
We tested this solution on our app and it works perfectly well. Previously, tapping the bottom tab would not scroll back to the top when a top tab bar was present, but this fixes the issue. You can find the package versions in the open issue.
Behavior example
Twitter has both top and bottom navigation bars. When tapping on the bottom tap, the screen scrolls back to the top. Tapping the top tab also scroll to the top.
Untitled.mp4