Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement 'slugPreprocessor' for V2 #29

Closed
Simek opened this issue Oct 2, 2020 · 2 comments
Closed

Reimplement 'slugPreprocessor' for V2 #29

Simek opened this issue Oct 2, 2020 · 2 comments
Labels
wontfix This will not be worked on

Comments

@Simek
Copy link

Simek commented Oct 2, 2020

Description

RN website still need this functionality:

@slorber
Copy link

slorber commented Oct 7, 2020

This one is a hard one.

Basically we'll need more than "slugPreprocessor", what we want is to have full control and create fixed ids, so that changing text does not break anchor links.

This is particularly important for i18n as translating a md title can lead to broken links on a localized site.

So I think we should find a way to explicitly define the ids instead of having id generation options. This also means that we'll have to check all existing RN website anchor links and apply the fixed id to the target.

Also related:
facebook/docusaurus#3321
facebook/docusaurus#3322

@Simek
Copy link
Author

Simek commented Oct 16, 2020

@slorber I think that this issue should not be a blocker for the migration. We have the page live with non-optimal content anchors for few months, before the slugPreprocessor feature. I we can try to fix this after the migration, I can also try to help with some tasks in Docusaurus repo to make it happen quicker 🙂

@Simek Simek added the wontfix This will not be worked on label Oct 16, 2020
@Simek Simek closed this as completed Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants