Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

v0.62.2 Discussion #188

Closed
alloy opened this issue Apr 8, 2020 · 31 comments
Closed

v0.62.2 Discussion #188

alloy opened this issue Apr 8, 2020 · 31 comments
Labels
backport request Cherry picking a change into an existing release stable Stable version

Comments

@alloy
Copy link
Member

alloy commented Apr 8, 2020

Conversations on this thread should be limited to reporting issues that are new in this minor version or requests to cherry-pick bug fixes that have landed in master.

In all other cases, please report the issue to http://github.com/facebook/react-native/issues.

@alloy alloy mentioned this issue Apr 8, 2020
1 task
@alloy alloy added backport request Cherry picking a change into an existing release stable Stable version labels Apr 8, 2020
@Maskedman99

This comment has been minimized.

@SaeedZhiany
Copy link

Can we cherry-pick this?
facebook/react-native@7980615

@alloy

This comment has been minimized.

@sunnylqm
Copy link
Contributor

facebook/react-native@449dc37

@guhungry
Copy link

guhungry commented Apr 12, 2020

Fix app crash due to flipper 0.33.1 in ios debug build when use base64 image facebook/react-native@17f025b

@SaeedZhiany

This comment has been minimized.

@sunnylqm

This comment has been minimized.

@SaeedZhiany

This comment has been minimized.

@sunnylqm

This comment has been minimized.

@christianbach
Copy link

christianbach commented Apr 14, 2020

Could we pick this?
facebook/react-native@7deeec7

For context:
react-native-community/cli#939
react-native-community/upgrade-support#26 (comment)

@naved971

This comment has been minimized.

@mikehardy

This comment has been minimized.

@Bardiamist

This comment has been minimized.

@ahce
Copy link

ahce commented Apr 21, 2020

Can pick this?
facebook/react-native@28dce36
facebook/react-native@7757ad0

@Knjaz89

This comment has been minimized.

@levibuzolic

This comment has been minimized.

@Knjaz89

This comment has been minimized.

@Bardiamist

This comment has been minimized.

@zhongwuzw
Copy link

Could we pick this facebook/react-native@9cdc19a?

@AnOptimistSeePessimist

This comment has been minimized.

@mikehardy

This comment has been minimized.

@chris-griffin
Copy link

Can we pick facebook/react-native@a2f8b9c which fixes an incorrect white text color being applied on TextInputs when an iOS device is set to dark mode even if the background of the input is white as well?

@glibenko
Copy link

glibenko commented May 31, 2020

Important info if you use Hermes
I updated from 61.5 to 62.2 and got a crash on android:
couldn't find DSO to load: libhermes-executor-debug.so

I fixed it by adding following string to android/app/build.gradle:
implementation "org.webkit:android-jsc:+"

@JLucasCAmorim
Copy link

Can we pick facebook/react-native@e5a6655 which fixes the Animated image crash when CADisplayLink target in RCTWeakProxy is nil?

@jakobvase
Copy link

jakobvase commented Jun 5, 2020

Can we pick facebook/react-native@33b3a1a? Changes the launch screen from .xib to .storyboard, as required by Apple before June 30th (https://developer.apple.com/news/?id=03262020b).

@SaeedZhiany
Copy link

@alloy
Are all the requested cherry-picks in this issue included in 0.63.x? If yes, we can close this issue right? otherwise, I'm wondering which version will include those cherry picks?

Thanks.

@chris-griffin
Copy link

I would definitely love to see these cherry-picks added to a new 62.2.3 release. This seems necessary especially given #188 (comment) (which will break things starting tomorrow). But in general, we would be very grateful to see additional stability in releases by backporting fixes to the previous major/minor patch.

@radko93
Copy link

radko93 commented Jun 29, 2020

@chris-griffin this only affects new projects, if you have an existing project you need to migrate to a storyboard manually anyway. But it has to be included in 0.63.

@kelset
Copy link
Member

kelset commented Jun 30, 2020

echoing what @radko93 just said, cherry picking the commit won't autofix/autoupdate any already existing app. That change needs to be done manually anyway, so in all fairness since we are releasing 0.63.0 very soon I don't think it's necessary to release 0.62.3 (since it won't come out before 0.63 anyway and react-native init will use 0.63).

@sunnylqm
Copy link
Contributor

sunnylqm commented Jul 4, 2020

@alloy
Copy link
Member Author

alloy commented Jul 6, 2020

Thanks for bearing with us and reporting issues/requests for picks 🙏 Due to available bandwidth, we decided to focus on getting a v0.63.0 release out rather than another v0.62.x patch release. I’ve gone through all the requested picks and have added those that are not yet slated for v0.63.0 to be picked for v0.63.1: #199

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport request Cherry picking a change into an existing release stable Stable version
Projects
None yet
Development

No branches or pull requests