-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove _JAVA_OPTIONS parameter & environment #172
Conversation
Have checked
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change so it will require a major bump
Indeed. Is there anything else worth updating as part of a breaking change? Could bump the default for |
Also worth noting for this PR that |
Do I need to do anything so that the semver bot understands the breaking change? |
Yup we use So your PR/Commit message should be updated |
161f3c1
to
ffa8a10
Compare
Can this PR get merged? |
ffa8a10
to
d737af9
Compare
# [8.0.0](v7.4.0...v8.0.0) (2024-05-23) ### Bug Fixes * remove _JAVA_OPTIONS parameter & environment (closes [#171](#171)) ([d737af9](d737af9)) * Merge pull request #172 from devnev/no-java-options-env ([a7d373e](a7d373e)), closes [#172](#172) ### BREAKING CHANGES * The java_options parameter has been removed. Specify your JVM options in the gradle.properties file or in the gradle_options with -Dorg.gradle.jvmargs= instead.
🎉 This PR is included in version 8.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Users should set org.gradle.jvmargs in their gradle.properties instead.
This fixes #171 where build failures caused by the unexpected output from java commands.
BREAKING CHANGE: The
java_options
parameter has been removed. Specify your JVM options in thegradle.properties
file or in thegradle_options
with-Dorg.gradle.jvmargs=
instead.