Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nested schema with computed-types #425

Merged
merged 1 commit into from Jul 7, 2022
Merged

Fix nested schema with computed-types #425

merged 1 commit into from Jul 7, 2022

Conversation

hlubek
Copy link
Contributor

@hlubek hlubek commented Jul 6, 2022

Having nested fields (represented by a nested Schema in computed-types) did not produce the expected error messages.

This change fixes it by using paths with dot syntax as the errors key, which will be correctly converted by toNestError.

@bluebill1049 bluebill1049 requested a review from jorisre July 6, 2022 23:02
bluebill1049
bluebill1049 approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@bluebill1049 bluebill1049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jorisre
jorisre approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@jorisre jorisre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

@jorisre jorisre merged commit fd1b2a7 into react-hook-form:master Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisre jorisre jorisre approved these changes

@bluebill1049 bluebill1049 bluebill1049 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hlubek @jorisre @bluebill1049