feat: add ajv

[jsun969]

There are 2 problems need to be solved

1. mjs file cannot be created when build. But I have add the build script.
2. If field is required, user must add minLength: 1 in the schema. Does this need to be optimized?

close #309

[getTobiasNielsen]

If field is required, user must add minLength: 1 in the schema. Does this need to be optimized?

I'm fairly sure that is how ajv want it to work.

[bluebill1049]

This is awesome! @jorisre would be able to help on the first issue since you are an expert on microbundle 😄

[jsun969]

If field is required, user must add minLength: 1 in the schema. Does this need to be optimized?

I'm fairly sure that is how ajv want it to work.

🤔 I think we can ignore the second issue. Just add some tips in documentation. What do you think? @bluebill1049

[bluebill1049]

🤔 I think we can ignore the second issue. Just add some tips in documentation. What do you think? @bluebill1049

thanks, @jsun969 I wouldn't add any "magic" to make it work, and try to stay as native as possible with AJV, at the end of the day people who decided to choose and use AJV resolver should have a clear understanding of its mechanism. By the way, this feature is awesome! so many users have asked for it and it's finally coming into pieces.

@damien-duignan I may borrow your eyes here as well.

cc @Moshyfawn

[jsun969]

🤔 I think we can ignore the second issue. Just add some tips in documentation. What do you think? @bluebill1049

thanks, @jsun969 I wouldn't add any "magic" to make it work, and try to stay as native as possible with AJV, at the end of the day people who decided to choose and use AJV resolver should have a clear understanding of its mechanism. By the way, this feature is awesome! so many users have asked for it and it's finally coming into pieces.

@damien-duignan I may borrow your eyes here as well.

cc @Moshyfawn

I get it! I'll make Ajv native. btw, I can add some ajv tips to documentation after merge if necessary

[bluebill1049]

thanks @jsun969 awesome to hear!

[jsun969]

I've fixed the first issue (build mjs error). Could you run the ci again 😄

[getTobiasNielsen]

Just to let you know how brilliant the kid is, I pointed out to @jsun969 that none of the other builds produced mjs, and he figured out something had to make the mjs in the code.

resolvers/config/node-13-exports.js

Lines 18 to 24 in af86e82

	const copySrc = () => {
	// Copy .module.js --> .mjs for Node 13 compat.
	fs.writeFileSync(
	`${process.cwd()}/dist/resolvers.mjs`,
	fs.readFileSync(`${process.cwd()}/dist/resolvers.module.js`),
	);
	};

Doesn't this solve the problem? (from microbundles docs)

I can see how having mjs, could make it more clear what type is it, and I guess you get more play with the node version.

[bluebill1049]

Awesome stuff, I will review it soon and get this to release soon! existing stuff.

[bluebill1049]

Looks amazing to me 🚀 Let's wait for @jorisre to give a review as well.

[bluebill1049]

hey @jorisre you are probably busy, I may merge and publish this feature this week. 🙏

[jorisre]

Thanks a lot @jsun969 ! 🚀 👏🏻

[github-actions]

🎉 This PR is included in version 2.9.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀