Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust contributing document #9641

Merged
merged 1 commit into from Dec 20, 2022
Merged

adjust contributing document #9641

merged 1 commit into from Dec 20, 2022

Conversation

stefanpl
Copy link
Contributor

Just opened my first PR on this project. Quality of the contributing docs was very nice, but still felt I could improve a few minor things:

  • put code in code blocks for better formatting
  • replace pnpm cypress with pnpm e2e (there's no "cypress" script", or am I missing something?)
  • add a little hint about running start and e2e in parallel

Thank you so much for react-hook-form 馃檹 馃帀 , me and the team 鉂わ笍 it

@codesandbox
Copy link

codesandbox bot commented Dec 20, 2022

CodeSandbox logoCodeSandbox logo聽 Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

bluebill1049
bluebill1049 approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@bluebill1049 bluebill1049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! thanks

@bluebill1049 bluebill1049 merged commit eb30119 into react-hook-form:master Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluebill1049 bluebill1049 bluebill1049 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stefanpl @bluebill1049