Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useTypedController #6

Open
lionskape opened this issue Mar 14, 2021 · 4 comments
Open

useTypedController #6

lionskape opened this issue Mar 14, 2021 · 4 comments

Comments

@lionskape
Copy link

lionskape commented Mar 14, 2021

Describe the solution you'd like
replace such lines:

import { useTypedController } from '@hookform/strictly-typed';
...
const TypedController = useTypedController<DealPlacementPositionValue>({ control });
...
<TypedController ... />
...

with

import { Controller } from 'react-hook-form';
...
<Controller contol={control} render={({field})} ... />
...

Additional context
We can create codemod for TypedController (from @hookform/strictly-typed package). It was working very similar way as a new Controller.

TODO:
Handle new structure of render properties

@jorisre
Copy link
Member

jorisre commented Mar 15, 2021

Thanks @lionskape Do you have more example to migrate ? I think it's hard to handle all uses cases.
We can use useController too in replacement of useTypedController

@bluebill1049 what's your thoughts ?

@bluebill1049
Copy link
Member

I am not codemod expert, I would assume migrate useTypedController would be tricky due to the input name itself is an array.

@lionskape
Copy link
Author

@jorisre Unfortunately, useController is not a replacement of useTypedController. useTypedController creates a component, but useController creates an object.

@bluebill1049 can you explain, what is a problem with name? Seems like we have to change array notation to the template string.

By the way - it would be very useful, because useTypedController will no longer be maintained react-hook-form/strictly-typed#29 (comment)

@bluebill1049
Copy link
Member

@bluebill1049 can you explain, what is a problem with name? Seems like we have to change array notation to the template string.

That's the problem which you have described, I think for any exiting useTypedControlled, you will have to manually convert to just useController.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants