docs: move default props to Dropzone component for react-docgen #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5fc4ffcf4ca71db905778fc559c3a38e0c08b839-PR-1015
💛 - Coveralls |
|
Any thoughts on this @rolandjitsu ? |
rolandjitsu
requested changes
Oct 14, 2020
Co-authored-by: Roland Groza <rolandjitsu@users.noreply.github.com>
rolandjitsu
approved these changes
Oct 14, 2020
|
🎉 This PR is included in version 11.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
Hello! This PR simply moves the default props from the hook to the defaultProps property on the Dropzone component, so that the defaults can be documented on the documentation site.
Current
With default props
Does this PR introduce a breaking change?
No!
Other information