From 2678140e56310186f0a98a7fe6c131abf14aee1a Mon Sep 17 00:00:00 2001 From: Seamus Lowry Date: Wed, 28 Apr 2021 19:18:34 -0400 Subject: [PATCH 1/5] check monitor for draggable --- packages/backend-html5/src/HTML5BackendImpl.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/backend-html5/src/HTML5BackendImpl.ts b/packages/backend-html5/src/HTML5BackendImpl.ts index a9359fdd30..7447af9d70 100644 --- a/packages/backend-html5/src/HTML5BackendImpl.ts +++ b/packages/backend-html5/src/HTML5BackendImpl.ts @@ -146,7 +146,7 @@ export class HTML5BackendImpl implements Backend { const handleDragStart = (e: any) => this.handleDragStart(e, sourceId) const handleSelectStart = (e: any) => this.handleSelectStart(e) - node.setAttribute('draggable', 'true') + node.setAttribute('draggable', this.monitor.canDragSource(sourceId)) node.addEventListener('dragstart', handleDragStart) node.addEventListener('selectstart', handleSelectStart) From 4023b33bcc846f0dffcf86e3acf76db21c5bbbec Mon Sep 17 00:00:00 2001 From: Seamus Lowry Date: Wed, 28 Apr 2021 19:22:45 -0400 Subject: [PATCH 2/5] versioning strategy with patch on changed repo and declined on all others --- .yarn/versions/cc76e3dc.yml | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 .yarn/versions/cc76e3dc.yml diff --git a/.yarn/versions/cc76e3dc.yml b/.yarn/versions/cc76e3dc.yml new file mode 100644 index 0000000000..158a362805 --- /dev/null +++ b/.yarn/versions/cc76e3dc.yml @@ -0,0 +1,8 @@ +releases: + react-dnd-html5-backend: patch + +declined: + - react-dnd-documentation + - react-dnd-examples-decorators + - react-dnd-examples-hooks + - react-dnd-test-utils From 882af846c09e0f819abffbc444c76120633ca620 Mon Sep 17 00:00:00 2001 From: Chris Trevino Date: Thu, 3 Feb 2022 15:15:29 -0800 Subject: [PATCH 3/5] fix: use string type for setting html attribute --- packages/backend-html5/src/HTML5BackendImpl.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/backend-html5/src/HTML5BackendImpl.ts b/packages/backend-html5/src/HTML5BackendImpl.ts index 7447af9d70..32fe8c8ec9 100644 --- a/packages/backend-html5/src/HTML5BackendImpl.ts +++ b/packages/backend-html5/src/HTML5BackendImpl.ts @@ -146,7 +146,9 @@ export class HTML5BackendImpl implements Backend { const handleDragStart = (e: any) => this.handleDragStart(e, sourceId) const handleSelectStart = (e: any) => this.handleSelectStart(e) - node.setAttribute('draggable', this.monitor.canDragSource(sourceId)) + if (this.monitor.canDragSource(sourceId)) { + node.setAttribute('draggable', 'true') + } node.addEventListener('dragstart', handleDragStart) node.addEventListener('selectstart', handleSelectStart) From 9c51c1f62a61f59f9261408d86815bbd737e9af1 Mon Sep 17 00:00:00 2001 From: Chris Trevino Date: Thu, 3 Feb 2022 15:17:08 -0800 Subject: [PATCH 4/5] fix: always set the draggable attribute on connectDragSource --- packages/backend-html5/src/HTML5BackendImpl.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/backend-html5/src/HTML5BackendImpl.ts b/packages/backend-html5/src/HTML5BackendImpl.ts index 41d9281fcb..a836fda5e2 100644 --- a/packages/backend-html5/src/HTML5BackendImpl.ts +++ b/packages/backend-html5/src/HTML5BackendImpl.ts @@ -149,9 +149,7 @@ export class HTML5BackendImpl implements Backend { const handleDragStart = (e: any) => this.handleDragStart(e, sourceId) const handleSelectStart = (e: any) => this.handleSelectStart(e) - if (this.monitor.canDragSource(sourceId)) { - node.setAttribute('draggable', 'true') - } + node.setAttribute('draggable', '' + this.monitor.canDragSource(sourceId)) node.addEventListener('dragstart', handleDragStart) node.addEventListener('selectstart', handleSelectStart) From 0668e55678d37ca3010337518cf51d5d032730b3 Mon Sep 17 00:00:00 2001 From: Chris Trevino Date: Thu, 3 Feb 2022 15:21:10 -0800 Subject: [PATCH 5/5] fix: update semver doc --- .yarn/versions/cc76e3dc.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.yarn/versions/cc76e3dc.yml b/.yarn/versions/cc76e3dc.yml index 158a362805..2083699570 100644 --- a/.yarn/versions/cc76e3dc.yml +++ b/.yarn/versions/cc76e3dc.yml @@ -3,6 +3,5 @@ releases: declined: - react-dnd-documentation - - react-dnd-examples-decorators - - react-dnd-examples-hooks + - react-dnd-examples - react-dnd-test-utils