Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing rootElement option causes dropEffect cursor failure #3099

Closed
tommoor opened this issue Feb 26, 2021 · 3 comments
Closed

Passing rootElement option causes dropEffect cursor failure #3099

tommoor opened this issue Feb 26, 2021 · 3 comments

Comments

@tommoor
Copy link

tommoor commented Feb 26, 2021

Describe the bug

When passing the new rootElement option to try and scope event listeners it introduces two problems:

  • There is a green (+) cursor that didn't previously appear
  • When releasing out of bounds the dragged item does not animate back to position as before

Screenshots

The only difference between these two videos is passing the rootElement option

Before

before.mp4

After

after.mp4

Desktop (please complete the following information):

  • OS: macOS Big Sur
  • Browser Chrome 88
  • Version 13.1.1

Additional context
Add any other context about the problem here.

@tommoor
Copy link
Author

tommoor commented Feb 26, 2021

It looks like the docs site was updated to use the rootElement prop and I'm not seeing the issue there, the mystery deepens…

@tommoor tommoor changed the title Passing rootElement option regresses display Passing rootElement option causes dropEffect cursor failure Feb 26, 2021
@tommoor
Copy link
Author

tommoor commented Mar 9, 2021

Just an update that I bumped to the latest releases as of yesterday 14.0.1 and tweaked the API as appropriate and the problem seems to persist. It's notable (in the video) that the green plus only appears on one of the useDrop areas, not the reordering line.

@tommoor
Copy link
Author

tommoor commented Mar 10, 2021

Upon further investigation it seems likely that this is a bug in react-dropzone that was exposed by the event target fix.

Ref: react-dropzone/react-dropzone#1042

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant