From 91265448c66b8da7b98c2b457209444679c95811 Mon Sep 17 00:00:00 2001 From: Seamus Lowry Date: Thu, 3 Feb 2022 18:28:04 -0500 Subject: [PATCH] Fix/draggable only when can drag (#3187) * check monitor for draggable * versioning strategy with patch on changed repo and declined on all others * fix: use string type for setting html attribute * fix: always set the draggable attribute on connectDragSource * fix: update semver doc Co-authored-by: Chris Trevino --- .yarn/versions/cc76e3dc.yml | 7 +++++++ packages/backend-html5/src/HTML5BackendImpl.ts | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 .yarn/versions/cc76e3dc.yml diff --git a/.yarn/versions/cc76e3dc.yml b/.yarn/versions/cc76e3dc.yml new file mode 100644 index 0000000000..2083699570 --- /dev/null +++ b/.yarn/versions/cc76e3dc.yml @@ -0,0 +1,7 @@ +releases: + react-dnd-html5-backend: patch + +declined: + - react-dnd-documentation + - react-dnd-examples + - react-dnd-test-utils diff --git a/packages/backend-html5/src/HTML5BackendImpl.ts b/packages/backend-html5/src/HTML5BackendImpl.ts index 50c6cdab80..0ce7a280dc 100644 --- a/packages/backend-html5/src/HTML5BackendImpl.ts +++ b/packages/backend-html5/src/HTML5BackendImpl.ts @@ -149,7 +149,7 @@ export class HTML5BackendImpl implements Backend { const handleDragStart = (e: any) => this.handleDragStart(e, sourceId) const handleSelectStart = (e: any) => this.handleSelectStart(e) - node.setAttribute('draggable', 'true') + node.setAttribute('draggable', '' + this.monitor.canDragSource(sourceId)) node.addEventListener('dragstart', handleDragStart) node.addEventListener('selectstart', handleSelectStart)