Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useMergedState.ts #264

Open
GuichiZhao opened this issue Jul 30, 2021 · 0 comments
Open

useMergedState.ts #264

GuichiZhao opened this issue Jul 30, 2021 · 0 comments

Comments

@GuichiZhao
Copy link

In triggerChange function, why not ignore setInnerValue when value present, i.e. controlled mode. I suppose innerValue does not take any effect in controlled mode though.

In addition, it should be nice to add some logic detecting the switch controlled and uncontrolled mode, throw an error/warning as native react dose facebook/react#5821.

Not sure if I am missing some points though, if the above idea make any sense. I am glad to implement the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant