New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: StrictMode modal scroll bar #174
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
发完得盯一下看看有没有 issue 提 bug |
是不是也修复了 ant-design/ant-design#27750 |
嗯,应该是的 |
ant-design/ant-design#26136 里检查一下,都解决了的话可以关掉。 |
1 task
Drawer 里的代码判断 openCount 是在 didmount 里判断的,导致拿到的是 0 。 另外,Drawer 里代码极其乱,overflow 的相关逻辑没有摘除干净,需要重构一下。 |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StrictMode 下
constructor
和getDerivedStateFromProps
会多次执行,导致openCount
数值错误。改造成了didMount
和didUpdate
不确定有没有坑。帮忙看下。close #ant-design/ant-design#28228