Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: StrictMode modal scroll bar #174

Merged
merged 4 commits into from Dec 8, 2020
Merged

fix: StrictMode modal scroll bar #174

merged 4 commits into from Dec 8, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Dec 7, 2020

StrictMode 下 constructorgetDerivedStateFromProps 会多次执行,导致 openCount 数值错误。改造成了 didMountdidUpdate 不确定有没有坑。帮忙看下。

close #ant-design/ant-design#28228

@coveralls
Copy link

coveralls commented Dec 7, 2020

Coverage Status

Coverage increased (+0.2%) to 43.624% when pulling 38be85c on open-count into cd5701e on master.

@zombieJ
Copy link
Member Author

zombieJ commented Dec 8, 2020

发完得盯一下看看有没有 issue 提 bug

@zombieJ zombieJ merged commit 6e8bb72 into master Dec 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the open-count branch December 8, 2020 02:43
@afc163
Copy link
Member

afc163 commented Dec 8, 2020

是不是也修复了 ant-design/ant-design#27750

@zombieJ
Copy link
Member Author

zombieJ commented Dec 8, 2020

嗯,应该是的

@afc163
Copy link
Member

afc163 commented Dec 8, 2020

ant-design/ant-design#26136 里检查一下,都解决了的话可以关掉。

@afc163
Copy link
Member

afc163 commented Dec 17, 2020

Drawer 里的代码判断 openCount 是在 didmount 里判断的,导致拿到的是 0 。

另外,Drawer 里代码极其乱,overflow 的相关逻辑没有摘除干净,需要重构一下。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants