Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use step status #197

Merged
merged 13 commits into from Sep 7, 2020
Merged

refactor: Use step status #197

merged 13 commits into from Sep 7, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Sep 6, 2020

使用 CSSMotion 的 onPreparerc-trigger 的对齐逻辑抽离出来。现在它将始终执行 measure & align 之后再进行动画。

ref ant-design/ant-design#26519

@zombieJ zombieJ requested a review from afc163 September 6, 2020 08:09
@codecov
Copy link

codecov bot commented Sep 6, 2020

Codecov Report

Merging #197 into master will increase coverage by 2.51%.
The diff coverage is 96.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
+ Coverage   85.65%   88.17%   +2.51%     
==========================================
  Files           7       10       +3     
  Lines         509      465      -44     
  Branches      143      121      -22     
==========================================
- Hits          436      410      -26     
+ Misses         73       55      -18     
Impacted Files Coverage Δ
src/index.tsx 83.38% <40.00%> (+1.15%) ⬆️
src/Popup/useVisibleStatus.ts 96.77% <96.77%> (ø)
src/Popup/Mask.tsx 100.00% <100.00%> (ø)
src/Popup/PopupInner.tsx 100.00% <100.00%> (ø)
src/Popup/index.tsx 100.00% <100.00%> (ø)
src/Popup/useStretchStyle.ts 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ac301f...bc353df. Read the comment docs.

@zombieJ zombieJ merged commit d50b065 into master Sep 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the next-motion branch September 7, 2020 02:16
@yoyo837 yoyo837 mentioned this pull request Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants