Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added keyof in OptionFilterProp #981

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Added keyof in OptionFilterProp #981

wants to merge 1 commit into from

Conversation

NextThread
Copy link

@NextThread NextThread commented Sep 17, 2023 •
edited

fixes: #930

@vercel
Copy link

vercel bot commented Sep 17, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
select ❌ Failed (Inspect) Sep 17, 2023 8:44am

@NextThread NextThread changed the title Added keyof in OptionFilterProp feat: Added keyof in OptionFilterProp Sep 17, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #981 (2a6338d) into master (b5fccbd) will not change coverage.
Report is 4 commits behind head on master.
The diff coverage is n/a.

❗ Current head 2a6338d differs from pull request most recent head cea869e. Consider uploading reports for the commit cea869e to get more accurate results

@@           Coverage Diff           @@
##           master     #981   +/-   ##
=======================================
  Coverage   99.78%   99.78%           
=======================================
  Files          38       38           
  Lines        1373     1373           
  Branches      400      375   -25     
=======================================
  Hits         1370     1370           
  Misses          3        3
Files Coverage Δ
src/Select.tsx 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yoyo837
Copy link
Member

yoyo837 commented Oct 13, 2023

Another code

select/src/hooks/useFilterOptions.ts

Line 15 in 83d5af3

optionFilterProp?: string,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use keyof
2 participants
@NextThread @yoyo837