Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move option aria to real element when virtual is disabled #888

Merged
merged 2 commits into from
Dec 14, 2022

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Dec 14, 2022

@vercel
Copy link

vercel bot commented Dec 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
select ❌ Failed (Inspect) Dec 14, 2022 at 3:40AM (UTC)

@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #888 (df05483) into master (1f3c35f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #888   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files          37       37           
  Lines        1339     1346    +7     
  Branches      356      360    +4     
=======================================
+ Hits         1334     1341    +7     
  Misses          4        4           
  Partials        1        1           
Impacted Files Coverage Δ
src/OptionList.tsx 99.33% <100.00%> (+0.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zombieJ zombieJ merged commit 55e8dd2 into master Dec 14, 2022
@zombieJ zombieJ deleted the a11y branch December 14, 2022 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant