Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no display of searchValue when autoClearSearchValue is false #863

Merged
merged 4 commits into from
Nov 15, 2022

Conversation

roelvdboom
Copy link
Contributor

@vercel
Copy link

vercel bot commented Nov 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
select ✅ Ready (Inspect) Visit Preview Nov 15, 2022 at 8:05AM (UTC)

@roelvdboom roelvdboom changed the title fix: clear of value bug when autoClearSearchValue is true fix: no display of searchValue when autoClearSearchValue is false Nov 11, 2022
@afc163
Copy link
Member

afc163 commented Nov 12, 2022

Could you add a test case for ant-design/ant-design#38515

@afc163
Copy link
Member

afc163 commented Nov 14, 2022

Please rebase master.

@roelvdboom
Copy link
Contributor Author

@afc163 I have added some tests

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #863 (f828988) into master (8f91ed3) will not change coverage.
The diff coverage is 100.00%.

❗ Current head f828988 differs from pull request most recent head e99ced8. Consider uploading reports for the commit e99ced8 to get more accurate results

@@           Coverage Diff           @@
##           master     #863   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files          37       37           
  Lines        1337     1337           
  Branches      355      355           
=======================================
  Hits         1332     1332           
  Misses          4        4           
  Partials        1        1           
Impacted Files Coverage Δ
src/BaseSelect.tsx 100.00% <ø> (ø)
src/Select.tsx 100.00% <ø> (ø)
src/Selector/index.tsx 100.00% <ø> (ø)
src/Selector/MultipleSelector.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@roelvdboom roelvdboom force-pushed the bug-autoClearSearchValue branch from 2725b70 to 093f101 Compare November 15, 2022 08:02
@afc163 afc163 merged commit 68662b1 into react-component:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select calls onSearch function with empty value when clicking for a second time in the input
2 participants