fix: Search focus lost compositing status #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/select/px9p28x75 |
afc163
commented
Sep 17, 2020
| @@ -40,7 +40,7 @@ const SingleSelector: React.FC<SelectorProps> = props => { | |||
| const [inputChanged, setInputChanged] = React.useState(false); | |||
|
|
|||
| const combobox = mode === 'combobox'; | |||
| const inputEditable = combobox || (showSearch && open); | |||
| const inputEditable = combobox || showSearch; | |||
There was a problem hiding this comment.
初始状态的 search input 就应该是 editable 状态，否则触发搜索后，输入法状态会被中断。
Codecov Report
@@ Coverage Diff @@
## master #548 +/- ##
=======================================
Coverage 99.37% 99.37%
=======================================
Files 20 20
Lines 956 956
Branches 311 311
=======================================
Hits 950 950
Misses 5 5
Partials 1 1
Continue to review full report at Codecov.
|
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ant-design/ant-design#26790