Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: can search disabled item #535

Merged
merged 1 commit into from Aug 31, 2020
Merged

fix: can search disabled item #535

merged 1 commit into from Aug 31, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Aug 31, 2020

@vercel
Copy link

vercel bot commented Aug 31, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/select/ddn4thips
✅ Preview: https://select-git-search-dis.react-component.vercel.app

@xrkffgg
Copy link
Member Author

xrkffgg commented Aug 31, 2020

我感觉 能查到,不能选,会更符合逻辑点

@xrkffgg xrkffgg requested review from zombieJ and afc163 August 31, 2020 02:24
@xrkffgg
Copy link
Member Author

xrkffgg commented Aug 31, 2020

或者 弄一个 选项 来设置?

@zombieJ
Copy link
Member

zombieJ commented Aug 31, 2020

设计如此,不是个 bug。弄个选项搞的有点复杂了。

@zombieJ
Copy link
Member

zombieJ commented Aug 31, 2020

我找设计师再对一对,看看是要改现在的逻辑还是不改。

@afc163
Copy link
Member

afc163 commented Aug 31, 2020

能查到不能选,确实更好一点,筛选归筛选,禁用归禁用,互不耦合。

@zombieJ
Copy link
Member

zombieJ commented Aug 31, 2020

同步了一下,禁用也可搜索到。

@zombieJ zombieJ merged commit 83eb019 into master Aug 31, 2020
@zombieJ zombieJ deleted the search-dis branch August 31, 2020 07:53
@zombieJ
Copy link
Member

zombieJ commented Aug 31, 2020

+ rc-select@11.1.7

@markusait
Copy link

Thanks for fixing this @xrkffgg will this change be in the latest antd version if I upgrade now?

@xrkffgg
Copy link
Member Author

xrkffgg commented Sep 1, 2020

Remove lock and node_modules, and install again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select Option disabled search is not working
4 participants