fix: incorrect display when value change from with label to without label #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1029 +/- ##
==========================================
- Coverage 99.78% 99.78% -0.01%
==========================================
Files 38 38
Lines 1398 1395 -3
Branches 418 391 -27
==========================================
- Hits 1395 1392 -3
Misses 3 3 ☔ View full report in Codecov by Sentry. |
yoyo837
reviewed
Feb 26, 2024
xulingling0
force-pushed
the
fix-1028-value
branch
from
00cca92
to
cb8a623
Compare
xulingling0
commented
Feb 28, 2024
| // Fill label by cache | ||
| const patchedValues = labeledValues.map((item) => { | ||
| if (item.label === undefined) { | ||
| return { | ||
| ...item, | ||
| label: prevValueCache.get(item.value)?.label, | ||
| label: prevOptionCache.get(item.value)?.label, |
There was a problem hiding this comment.
此处不一定取label, 需结合
zombieJ
reviewed
Feb 28, 2024
| */ | ||
| export default ( | ||
| labeledValues: LabelInValueType[], | ||
| valueOptions: Map<RawValueType, DefaultOptionType>, | ||
| ): [LabelInValueType[], (val: RawValueType) => DefaultOptionType] => { | ||
| const cacheRef = React.useRef({ | ||
| values: new Map<RawValueType, LabelInValueType>(), |
There was a problem hiding this comment.
这个不应该删掉，labelInValue 的时候需要 cache 住之前的 label。只有不设置 labelInValue 才应该清理掉。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1028