Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated event.which property #696

Open
chilled-capybara opened this issue Nov 22, 2023 · 1 comment · May be fixed by #697
Open

Deprecated event.which property #696

chilled-capybara opened this issue Nov 22, 2023 · 1 comment · May be fixed by #697

Comments

@chilled-capybara
Copy link

Similar issue to react-component/select; react-component/select#977

event.which is deprecated which is causing issues with @testing-library/user-event v14; testing-library/user-event#1137

Deprecated: This feature is no longer recommended. Though some browsers might still support it, it may have already been removed from the relevant web standards, may be in the process of being dropped, or may only be kept for compatibility purposes. Avoid using it, and update existing code if possible; see the compatibility table at the bottom of this page to guide your decision. Be aware that this feature may cease to work at any time.

It's recommended to switch over to event.code or event.key instead - testing-library/user-event#842 (comment)
@afc163
Copy link
Member

afc163 commented Nov 23, 2023

PR is welcome~

@chilled-capybara chilled-capybara linked a pull request Dec 12, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update deprecated keyboard event props chilled-capybara/react-component-picker
2 participants
@afc163 @chilled-capybara