Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to be closed with a click anywhere in the toast #46

Open
abenhamdine opened this issue Jul 29, 2018 · 2 comments
Open

Allow to be closed with a click anywhere in the toast #46

abenhamdine opened this issue Jul 29, 2018 · 2 comments

Comments

@abenhamdine
Copy link

abenhamdine commented Jul 29, 2018 •
edited

Currently, when closable is true, a close button is displayed.

Some users complain because it is somehow tedious to click on a small button and would prefer to click anywhere in the toast to close it.

Most of notifications libraries allow it, see eg https://github.com/fkhadra/react-toastify
@yesmeck
Copy link
Member

yesmeck commented Jul 30, 2018

We can add a closeOnClick prop.

@abenhamdine
Copy link
Author

We can add a closeOnClick prop.

Looks good.
thx for your quick answer !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yesmeck @abenhamdine