-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to close notification since on release v4.5.0 #148
Comments
+1 Here is reproduce: If you upgrade the rc-notification package version, you will see notification not closing automatically. I downgrade the package version to 4.4.0 and solved for me |
@afc163 Is this project still alive? Pin the |
same issue i cannot close the button using Close Button |
Same problem here, even the simplest Demo from https://notification-react-component.vercel.app/demo/hooks doesn't work for me - notifications don't disappear. Using React 17.0.2 + rs-notifications 4.5.7. |
I found that after using removeNotice(key), the *-fade-leave class will be added to the corresponding div, and you can use *-fade-leave to control the display/hide of the notification content through css, which can solve the problem. |
Our component library has been using rc-notification, and closing the notification started to not work since release v4.5.0. To be more specific, removeNotice method gets called, and I see that the notices array in the React state of rc-notification module removes the correct item. However, the state change does not get reflected in the UI, and the notification does not disappear from the screen.
Expected behavior:
Current behavior:
The text was updated successfully, but these errors were encountered: