Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no way to disable the close button #417

Open
Ke1sy opened this issue Apr 24, 2024 · 1 comment
Open

There is no way to disable the close button #417

Ke1sy opened this issue Apr 24, 2024 · 1 comment

Comments

@Ke1sy
Copy link

Ke1sy commented Apr 24, 2024

In our project we have the form inside the dialog and a potentially long-running API call that is made upon clicking the “ok” button and we need to prevent the user from closing the modal while the API call is still pending. Currently there is no way to disable close (X) button while the API is still in flight.
According to our design the modal should be closable, so I cannot use closable={false}.
I propose to add an additional prop closeBtnIsDisabled that will allow user to disable the close button.
Let me know if you accept such PR.

@Ke1sy
Copy link
Author

Ke1sy commented Apr 24, 2024

@yoyo837 @zombieJ @MadCcc Let me know if you accept such PR in rc-dialog and later in antd. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant