Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dialog should not auto destroy #206

Merged
merged 2 commits into from Oct 14, 2020
Merged

fix: Dialog should not auto destroy #206

merged 2 commits into from Oct 14, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Oct 14, 2020

@vercel
Copy link

vercel bot commented Oct 14, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/dialog/l84q82x8a
✅ Preview: https://dialog-git-fix-des.react-component.vercel.app

@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #206 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #206   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files           5        5           
  Lines         154      154           
  Branches       45       46    +1     
=======================================
  Hits          151      151           
  Misses          2        2           
  Partials        1        1           
Impacted Files Coverage Δ
src/DialogWrap.tsx 94.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af18417...5c6cdd7. Read the comment docs.

@zombieJ zombieJ merged commit 44fb747 into master Oct 14, 2020
@zombieJ zombieJ deleted the fix-des branch October 14, 2020 03:04
@afc163
Copy link
Member

afc163 commented Oct 14, 2020

antd changelog 也应该改掉。

@zombieJ
Copy link
Member Author

zombieJ commented Oct 14, 2020

嗯,应该是 destroyOnClose 会清理相关节点,bug 被当 feature 了 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Need update documents]in antd lastest, modal destory when close, and i don't set destroyOnClose
2 participants