Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Portal event bubble #204

Merged
merged 2 commits into from Oct 11, 2020
Merged

fix: Portal event bubble #204

merged 2 commits into from Oct 11, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Oct 11, 2020

@vercel
Copy link

vercel bot commented Oct 11, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/dialog/hzwndwfwd
✅ Preview: https://dialog-git-fix-nest.react-component.vercel.app

@zombieJ zombieJ changed the title Fix nest fix: Portal event bubble Oct 11, 2020
@codecov
Copy link

codecov bot commented Oct 11, 2020

Codecov Report

Merging #204 into master will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
+ Coverage   97.91%   98.05%   +0.13%     
==========================================
  Files           5        5              
  Lines         144      154      +10     
  Branches       43       45       +2     
==========================================
+ Hits          141      151      +10     
  Misses          2        2              
  Partials        1        1              
Impacted Files Coverage Δ
src/Dialog/Content.tsx 95.23% <ø> (ø)
src/Dialog/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cc8bc0...7595921. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant