Ensure Consistent API for custom variants #6398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanolee
changed the title
kyletsang
approved these changes
Jul 15, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR follows on from #4461 and aims to ensure consistency when using custom variants across react bootstrap. Currently a number of components do not properly support custom variants in the way the issue was resolved as not everything uses Variant as a base. (Such as Navbar).
Why
Given this looks to be the agreed upon approach for custom variants all
variantattributes might need a type of "| string" addingHow
By adding "| string" to the remaining typedefs where variant is still using a Union of hardcoded values. This should not cause any bc breaks as it is extending hardcoded unions of strings.
Thanks for looking at this!