New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FormSelect) props not being defined #6106

Merged

kyletsang merged 2 commits into react-bootstrap:master from lcheunglci:fix-missing-formselect-props

Oct 29, 2021

Contributor

lcheunglci commented Oct 29, 2021 •

edited

Fixes #6105 by changing HTMLAttributes to SelectHTMLAttributes in FormSelect

lcheunglci added 2 commits

October 28, 2021 18:39


          change HTMLAttributes to SelectHTMLAttributes

c81484a


          Omit size from interface since we use string instead of number to fix…

9ac432a

… compile error

kyletsang approved these changes

View reviewed changes

kyletsang merged commit 4dd40db into react-bootstrap:master

Member

kyletsang commented Oct 29, 2021

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment