Fixed homepage appearance in mobile view #5827
Conversation
|
@kyletsang Can you please review!? |
www/src/pages/index.js
Outdated
| @@ -84,7 +84,7 @@ const ButtonToolbar = styled('div')` | |||
| margin: -1rem; | |||
|
|
|||
| & > * { | |||
| width: 100%; | |||
| width: 90%; | |||
There was a problem hiding this comment.
I think it's better to use calc() here because the width does not account for the margins hence the overflow
|
The Website doesn't looks good after the update on desktop, this reduced height isn't better. Maybe, separate code base for height on mobile and desktop |
There is no significant visible difference I can see with this code change. If you can send screenshot we will get to know more, otherwise i think everything is working fine |
|
After using calc():
|
|
@kyletsang I have made required changes. Please review |
www/src/pages/index.js
Outdated
| @@ -84,7 +84,7 @@ const ButtonToolbar = styled('div')` | |||
| margin: -1rem; | |||
|
|
|||
| & > * { | |||
| width: 100%; | |||
| width: calc(100% - 1.85rem); | |||
There was a problem hiding this comment.
Should actually be calc(100% - 2rem) since the margins added on each side sum up to 2.
|
@kyletsang Made the required changes. Can you please review! |
Fixed issue #5797
Mobile View
Before :
After:
Web View
Before:
After: