-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to 'as' as prop in NavDropdown #5576
Support to 'as' as prop in NavDropdown #5576
Conversation
@kyletsang Should I include tests that checks every single |
A single |
Thanks looks good to me. @jquense, double checking this with you :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems ok...this works because NavItem has no logic in it right? it's purely presentational? Maybe we should make a little note about that
Yeah NavItem is purely presentational. Could probably shrink that to |
So, should I comment line 83 with something like |
Maybe something like You can leave a TODO note in NavItem if you want. I was thinking of reducing some code in v5 branch later on. |
Thanks! |
What does this PR do?
Supports
as
as prop in NavDropdown.Description of tasks completed
as
:PropTypes.elementType
toNavDropdown
component.What is the related issue?
#5552