Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readable-stream #4

Closed
tpluscode opened this issue Apr 23, 2020 · 1 comment
Closed

Update readable-stream #4

tpluscode opened this issue Apr 23, 2020 · 1 comment

Comments

@tpluscode
Copy link
Contributor

Currently the different parser and serialiser packages refer to incompatible versions of readable-stream 2.x and 3.x

Here's npm ls readable-stream --prod from alcaeus

alcaeus@1.0.0-alpha.16 /Users/tomaszpluskiewicz/projects/github/wikibus/heracles
├─┬ @rdfjs/formats-common@2.1.0
│ ├─┬ @rdfjs/parser-jsonld@1.2.0
│ │ ├─┬ concat-stream@1.6.2
│ │ │ └── readable-stream@2.3.7
│ │ └── readable-stream@2.3.7
│ ├─┬ @rdfjs/parser-n3@1.1.3
│ │ └── readable-stream@2.3.7
│ ├─┬ @rdfjs/serializer-jsonld@1.2.1
│ │ └── readable-stream@2.3.7
│ └─┬ @rdfjs/serializer-ntriples@1.0.3
│   └─┬ readable-to-readable@0.1.3
│     └── readable-stream@3.6.0  deduped
├─┬ rdf-dataset-indexed@0.4.0
│ └── readable-stream@3.6.0  deduped
├─┬ rdf-transform-triple-to-quad@1.0.2
│ └── readable-stream@3.6.0  deduped
└── readable-stream@3.6.0

I create this issue to track PRs which will update the dependencies' dependencies to have a single resolution of readable-stream@^3

@bergos
Copy link
Contributor

bergos commented Oct 9, 2022

All @rdfjs packages have been updated. Only n3 still depends on 3.x of readable-stream. I opened an issue to publish a new release. Until there is a new release, it's possible to use overrides like here. As there is a workaround and an open issue in the n3 package, I will close this issue.

@bergos bergos closed this as completed Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants