Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/version: add support for openbsd/386 #5537

Closed
2 tasks done
ivandeex opened this issue Aug 16, 2021 · 3 comments · Fixed by #5567
Closed
2 tasks done

cmd/version: add support for openbsd/386 #5537

ivandeex opened this issue Aug 16, 2021 · 3 comments · Fixed by #5567
Assignees
Labels
Milestone

Comments

@ivandeex
Copy link
Member

ivandeex commented Aug 16, 2021

The associated forum post URL from https://forum.rclone.org

N/A

What is your current rclone version (output from rclone version)?

master branch

What problem are you are trying to solve?

rclone version is a stub for openbsd/386.

When I merged #5402 I thought that upstream issue tklauser/go-sysconf#21 depends on the core golang schedule.
Now that @tklauser closed it in less than a week I see that in fact https://github.com/tklauser/go-sysconf depends on fast-moving https://pkg.go.dev/golang.org/x/sys?tab=versions

How do you think rclone should be changed to solve that?

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.
@ivandeex ivandeex added the build label Aug 16, 2021
@ivandeex ivandeex added this to the v1.57 milestone Aug 16, 2021
@ivandeex ivandeex self-assigned this Aug 16, 2021
@tklauser
Copy link
Contributor

The associated forum post URL from https://forum.rclone.org

N/A

What is your current rclone version (output from rclone version)?

master branch

What problem are you are trying to solve?

rclone version is a stub for openbsd/386.

When I merged #5402 I thought that upstream issue tklauser/go-sysconf#21 depends on the core golang schedule.
Now that @tklauser closed it in less than a week I see that in fact https://github.com/tklauser/go-sysconf depends on fast-moving https://pkg.go.dev/golang.org/x/sys?tab=versions

FWIW, during the Go development freeze (see https://github.com/golang/go/wiki/Go-Release-Cycle for details), x/sys is usually frozen as well (i.e. id depends on the core Go development schedule) because is vendored into cmd/vendor. Thus the CL above was blocked from being merged for a week. We were lucky that the development cycle opened just today 😄.

How do you think rclone should be changed to solve that?

1. Submit pull request for https://github.com/shirou/gopsutil to upgrade to https://github.com/tklauser/go-sysconf/releases/tag/v0.3.8

I've submitted shirou/gopsutil#1117 a few minutes ago bumping go-sysconf in gopsutil.

@ivandeex
Copy link
Member Author

@tklauser Got you. Thanks a lot.

@tklauser
Copy link
Contributor

tklauser commented Sep 1, 2021

@ivandeex FYI, gopsutil v3.21.8 was released some hours ago and should contain the bumped go-sysconf (shirou/gopsutil#1117), hopefully allowing this issue to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants