Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to new rollup version #1087

Closed
saurabhdaware opened this issue Mar 23, 2023 · 9 comments
Closed

Upgrade to new rollup version #1087

saurabhdaware opened this issue Mar 23, 2023 · 9 comments
Assignees
Labels
P1 Kinda Important

Comments

@saurabhdaware
Copy link
Member

          Can't we upgrade our rollup version and use this?

Originally posted by @chaitanyadeorukhkar in #1045 (comment)

We would be able to remove custom babel plugin of manualPureFunction with it.

TODO:

  • Check new features that it offers
  • Check breaking changes
  • Upgrade
@saurabhdaware saurabhdaware changed the title feat: Upgrade to new rollup version Upgrade to new rollup version Mar 23, 2023
@divyanshu013 divyanshu013 added the P1 Kinda Important label Apr 19, 2023
@loombarishav
Copy link

loombarishav commented Apr 26, 2023

interested to work on rollUp upgrade in Blade.

Quick small question

  1. Any specific version we are targeting.
  2. Any specific feature we are looking at after upgrade

@divyanshu013 @saurabhdaware

@saurabhdaware
Copy link
Member Author

Any specific version we are targeting.

We are looking to move to latest version

Any specific feature we are looking at after upgrade

One particular we're looking for is -

I think rest are the things we can pick one-by-one when usecase comes and that feature is required. Currently we can just focus to migrate and fix breaking changes.

@loombarishav
Copy link

Thanks @saurabhdaware. Got It.
I am planning to pick this task. Will update on this thread

@saurabhdaware
Copy link
Member Author

awesome! thanks 👯 Let us know if you need some help.

@loombarishav
Copy link

Sure Thanks!

@kamleshchandnani
Copy link
Collaborator

@loombarishav do you have an ETA to finish this?

@loombarishav
Copy link

I picked this task in Q1 S4 sprint, but due to some P0 feature delivery (3 weeks work), I moved this to backlog. And after that i forgot to pick this task again. My bad.
Surely Will pick and complete this in next sprint (Already packed heavily in this sprint).
@kamleshchandnani

@snitin315 snitin315 linked a pull request Sep 4, 2023 that will close this issue
@snitin315 snitin315 assigned snitin315 and unassigned loombarishav Sep 4, 2023
@snitin315
Copy link
Member

@saurabhdaware I tried this new option but it doesn't seem to be working as expected. I see size-limit crossing if I remove the babel-plugin and use this option.

Screenshot 2023-09-04 at 8 45 56 AM Screenshot 2023-09-04 at 8 44 30 AM

@snitin315 snitin315 removed a link to a pull request Sep 4, 2023
@anuraghazra
Copy link
Member

Done as part of #1563

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Kinda Important
Projects
None yet
Development

No branches or pull requests

6 participants