Update compat-Cargo.lock #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, compat-Cargo.lock could have been updated during CI, if Cargo.toml is changed. This can lead to spurious build failures when testing MSRV, because not all dependencies are effectively locked.
|
Good catch, thank you! bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 7, 2019
705: Update compat-Cargo.lock r=cuviper a=matklad I've noticed that #704 uses old compat lockfile, which is strange, given that it changes Cargo.lock. What happens here is that cargo writes new compat lockfile during CI. That means that CI might break randomly, if rayon's dependency is published with the same major version, but different MSRV With this PR, CI will break deterministically if you change Cargo.toml and don't update compat-Cargo.lock. Not sure if this actually makes sense :) Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that #704 uses old compat lockfile, which is strange, given that it changes Cargo.lock.
What happens here is that cargo writes new compat lockfile during CI.
That means that CI might break randomly, if rayon's dependency is published with the same major version, but different MSRV
With this PR, CI will break deterministically if you change Cargo.toml and don't update compat-Cargo.lock.
Not sure if this actually makes sense :)