Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of date flags in the Development Guide section of the wiki #622

Closed
seanchen1991 opened this issue Jan 13, 2019 · 3 comments
Closed

Out of date flags in the Development Guide section of the wiki #622

seanchen1991 opened this issue Jan 13, 2019 · 3 comments

Comments

@seanchen1991
Copy link
Contributor

After forking and attempting to run cargo test --features unstable locally, I get a rayon does not have these features: unstable error. Running without the unstable flag seems to work perfectly fine; no warnings about dead code in sight. I can go and update the cargo commands in the wiki if y'all are fine with removing the --features unstable flag.

@cuviper
Copy link
Member

cuviper commented Jan 18, 2019

Hmm, yes, we switched that to a manual cfg flag a while ago (#371). These days it's only used for futures integration, which is why it's only described in the rayon-futures README. We no longer need to advise using that all the time. You can now also use stable rustc for testing and the demos, although I suppose you still need nightly for benchmarks.

@nikomatsakis
Copy link
Member

We have a wiki? :) I forgot all about that.

@nikomatsakis
Copy link
Member

I removed the mention of --features unstable, at least. Closing this issue for now. Thanks @seanchen1991 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants